Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote gossipsub v1.1 spec to Candidate Recommendation #269

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented May 13, 2020

Reference implementation is https://github.com/libp2p/go-libp2p-pubsub/, conformant to the promoted spec as of libp2p/go-libp2p-pubsub#263, and follow-ups.

@vyzo vyzo requested review from yusefnapora, raulk and daviddias May 13, 2020 09:41
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but need to wait 10 days before merging, in case someone wants to contest.

@Stebalien
Copy link
Member

We should probably cut a release of pubsub first.

@vyzo
Copy link
Contributor Author

vyzo commented May 13, 2020

Yeah, planned for this Friday.

@daviddias
Copy link
Member

daviddias commented May 22, 2020

image

Just one more day :D

@raulk
Copy link
Member

raulk commented May 22, 2020

@daviddias
giphy (1)

@jacobheun
Copy link
Contributor

This CR has been approved and open for over a month (longer than the required 10 days), merging.

@jacobheun jacobheun merged commit c97c05a into master Jun 29, 2020
@jacobheun jacobheun deleted the update/gossipsub-v1.1-candidate-recommendation branch June 29, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants