-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote gossipsub v1.1 spec to Candidate Recommendation #269
Merged
jacobheun
merged 4 commits into
master
from
update/gossipsub-v1.1-candidate-recommendation
Jun 29, 2020
Merged
Promote gossipsub v1.1 spec to Candidate Recommendation #269
jacobheun
merged 4 commits into
master
from
update/gossipsub-v1.1-candidate-recommendation
Jun 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
approved these changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but need to wait 10 days before merging, in case someone wants to contest.
We should probably cut a release of pubsub first. |
Yeah, planned for this Friday. |
yusefnapora
approved these changes
May 13, 2020
daviddias
approved these changes
May 19, 2020
This CR has been approved and open for over a month (longer than the required 10 days), merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference implementation is https://github.com/libp2p/go-libp2p-pubsub/, conformant to the promoted spec as of libp2p/go-libp2p-pubsub#263, and follow-ups.