Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multidim-interop: Support passing in a custom timeouts #107

Closed
MarcoPolo opened this issue Jan 17, 2023 · 1 comment
Closed

multidim-interop: Support passing in a custom timeouts #107

MarcoPolo opened this issue Jan 17, 2023 · 1 comment

Comments

@MarcoPolo
Copy link
Contributor

When testing with browsers, we may need higher timeouts than 10s (may take a bit to startup the browser). However it would be a shame to increase timeouts everywhere when it's just the browser nodes that may be a little slower.

I'm thinking we could have another env param that defines a larger timeout when there is a browser node in the test.
@thomaseizinger thomaseizinger mentioned this issue Jan 20, 2023
Merged
@MarcoPolo
Copy link
Contributor Author

Completed in #104. This is optionally passed into tests as test_timeout env param.

This was referenced Jan 24, 2023
Merged
Merged
mergify bot pushed a commit to libp2p/rust-libp2p that referenced this issue Jan 25, 2023
@MarcoPolo
feat(ci): Add support for test_timeout option (#3379)
1b45d5e 
Node and browser tests take a little bit longer to spin up in the interop tests. The multidim-interop can tell the tests to increase the timeout when testing against these targets, but the test itself needs to use the passed in value.

This updates the test code to handle the new test_timeout option. See libp2p/test-plans#107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarcoPolo