Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbar problems v2 #2086

Closed
3 tasks done
Silther opened this issue Nov 26, 2022 · 4 comments
Closed
3 tasks done

Searchbar problems v2 #2086

Silther opened this issue Nov 26, 2022 · 4 comments
Labels
bug Something isn't working help wanted Looking for help

Comments

@Silther
Copy link
Contributor

Silther commented Nov 26, 2022

Steps to reproduce

(For more context see #1599.)

  1. Search multiple times.

  2. If the search was opened and the app is a few minutes in the background, the searchbar is closed when you return.

Expected behavior

You should go back to the last search result.

Actual behavior

The searchbar closes.

LibreTube version

0.8.0

Android version

Android 12 One UI 4.1

Other details

Screen_Recording_20221121_225952_LibreTube.Debug.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Silther Silther added the bug Something isn't working label Nov 26, 2022
@Bnyro Bnyro added the help wanted Looking for help label Feb 5, 2023
@SajalRG
Copy link
Contributor

SajalRG commented May 26, 2023

Hi @Bnyro , With the new pull request #3831, search-bar closing issue is fixed as reported here. However, the query string won't reset to previous one.

search-page-back-press.webm

Do we expect search text also to be previous one?
I feel when pressing back the search text also should be replaced. Same behaviour is there in Youtube as well.
Let me know your thoughts.

@Bnyro
Copy link
Member

Bnyro commented May 26, 2023

@SajalRG
Yes, that could be a valuable improvement, but I think the current way works well enough for now.
However since it's not part of this issue, I'll be closing this one now since your previous PR already fixed that!

@Bnyro Bnyro closed this as completed May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Looking for help
Projects
None yet
Development

No branches or pull requests

4 participants
@SajalRG @Bnyro @Silther and others