-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search bar collapse while search in progress #3831
Conversation
a3108f8
to
e0d9105
Compare
Verified all cases below working as expected.
This PR closes Issue #1965 |
https://issuetracker.google.com/issues/244336571#comment22 Could this issue also be fixed if we just include the latest version of the dependency in LibreTube directly? |
Yeah, I thought trying same but couldn't find where LibreTube including fragment dependency (i.e. androidx.fragment:fragment), hence added the workaround for now and shared for review. Edit: Also as per the comment, the library is still not released and is in alpha stage. That comment was 2 months ago so not sure of actual release status though. |
app/src/main/java/com/github/libretube/ui/activities/MainActivity.kt
Outdated
Show resolved
Hide resolved
Tested it and can confirm this fixes the issue. |
This is an AOSP bug where destroy of fragment calls invalideMenu of Activity even though the fragment does not participate in menu updates. https://issuetracker.google.com/issues/244336571 Hence added an workaroud to not invalidate menu when search is in progress.
e0d9105
to
edf487c
Compare
Hi @Bnyro , updated commit as per your suggestion. Please review. Thanks :) |
This is an AOSP bug where destroy of fragment calls invalideMenu of Activity even though the fragment does not participate in menu updates.
https://issuetracker.google.com/issues/244336571
Hence added an workaroud to not invalidate menu when search is in progress.
Closes #1965