Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add picture-in-picture helper classes. #3411

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Add picture-in-picture helper classes. #3411

merged 2 commits into from
Mar 28, 2023

Conversation

Isira-Seneviratne
Copy link
Collaborator

No description provided.

Bnyro
Bnyro approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Just one note: com.github.libretube.ui.extensions#SetAspectRatio isn't needed anymore after the change, so it'd be great if you could already remove that within this PR.

@Bnyro Bnyro merged commit 29a855d into libre-tube:master Mar 28, 2023
@Isira-Seneviratne Isira-Seneviratne deleted the Pip_compat branch March 28, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isira-Seneviratne @Bnyro