feat: display full video sponsorblock categories

[FineFindus]

Displays the full SponsorBlock categories as a chip below the video, similar to how the web version works

[FineFindus]

Maybe it would be better to move the badge into the same line as the title? Having it above leaves a lot of empty space.

[Bnyro]

Maybe it would be better to move the badge into the same line as the title? Having it above leaves a lot of empty space.

None of it is a perfect solution, but I'd personally prefer having the badge on a different line than the title.

We can decrease the padding between the video and the title though if the badge is visible, so that it's at least taking a little bit less total space.

[Bnyro]

Last but not least, please add a preference at https://github.com/libre-tube/LibreTube/blob/master/app/src/main/res/xml/sponsorblock_settings.xml to allow users to toggle displaying the sponsor categories (can be enabled by default).

Apart from the other comment above, lgtm.

[FineFindus]

I'm not a fan of adding new preferences, could we use the existing sponsor category (or even SponsorBlock being enabled all together) for it? I think it already covers use case of not wishing to see the sponsor hints.

[Bnyro]

I'm not a fan of adding new preferences

I agree with this generally, I'm not too sure about it because it's quite a big chip there above the title that not everybody might be comfortable with.

If we find a better way to display it (e.g. collapsed by default in the description layout), we definitely won't need a new preference.

[FineFindus]

If we find a better way to display it (e.g. collapsed by default in the description layout), we definitely won't need a new preference.

I was thinking about doing that, but I feel like it would defeat the purpose, since a user is unlikely to look in the description, and atleast the sponsor badge is something that should be very visible

[Bnyro]

Sorry for the conflicts, I refactored the app to use the MediaLibraryService to unify a lot of logic and improve the stability of the background playback.

[Bnyro]

actionType needs to be passed at https://github.com/libre-tube/LibreTube/blob/master/app/src/main/java/com/github/libretube/services/OnlinePlayerService.kt#L215 now.

[Bnyro]

Thanks!