feat(Playlist): display views and upload date #6920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the Piped API now provides the number of views/upload date for a playlist item, we can display them in the playlist view. Ref: libre-tube#4401
FineFindus
force-pushed
the
feat/playlist-views
branch
from
aeb6a50 to
d0d9deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Piped API now provides the number of views/upload date for a playlist item, we can display them in the playlist view.
Ref: #4401
This however leads to the channel being displayed below the views/upload date, which is suboptimal. I'm not sure what is the best way to solve that, either displaying it the info line itself (like for other related streams) or modifying to view to display it above the video info?Since related streams already show channel, views and upload date in this way, I think it is best to continue doing so here. It also works when the information is missing, such as when using created playlists.