Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New RSS Feed Entry - increasement of minimum version #11526

Closed
wants to merge 4 commits into from

Conversation

SourceDoctor
Copy link
Member

update for RSS File

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@@ -73,5 +73,10 @@
<description>Cisco WLC is now classified as type "Wireless" instead of "Network". Update any alert rules you may have.</description>
<pubDate>Wed, 18 Dec 2019 00:00:00 +0000</pubDate>
</item>
<item>
<title>Minimum Requirements for PHP and Python changed</title>
<description><![CDATA[To keep LibreNMS uptodate it's necessary to increase minimum Requirements of PHP and Python<br/>PHP 7.2.5<br/>Python 3.4<br/>Please ensure you have at least this versions installed.<br/>For further information read Article in <a href="https://community.librenms.org/t/dropping-support-for-php-7-1-and-python-2/11851">Community</a>.]></description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't show any content in the notifications.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what did i miss?

@murrant
Copy link
Member

murrant commented May 4, 2020

This should be in the website rss so everyone gets it.

@SourceDoctor
Copy link
Member Author

am i in the wrong project with this PR?

@Jellyfrog Jellyfrog mentioned this pull request May 4, 2020
@murrant
Copy link
Member

murrant commented May 8, 2020

There are two RSS feeds. This one is loaded at update time of LibreNMS. The website one is checked daily by all installs.

@murrant
Copy link
Member

murrant commented May 8, 2020

And as I said, we don't seem to support CDATA

@SourceDoctor
Copy link
Member Author

yeah i saw the notification coming up this morning. Therefore this PR was thought.
Thinking this here could be closed then?

@murrant
Copy link
Member

murrant commented May 9, 2020

Yeah, only need one notification. Thanks @SourceDoctor

@murrant murrant closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants