-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove and update dependencies #1140
Conversation
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Needed to increase MSRV to |
|
b21788c
to
79ecf51
Compare
Signed-off-by: Christian König <[email protected]>
79ecf51
to
cd1f16e
Compare
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Needed to increase MSRV to 1.64 |
8746206
to
8ad5d56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some things that I noticed. :)
Thanks for your review.
Because this is trial and error. As I said above:
_ I'll try to get it working but I might need more help on that. |
1be0ac9
to
e3771e5
Compare
Signed-off-by: Christian König <[email protected]>
e3771e5
to
1e4c324
Compare
Signed-off-by: Christian König <[email protected]>
db359a9
to
f4ec772
Compare
Signed-off-by: Christian König <[email protected]>
8fe0eb2
to
379c127
Compare
This PR consists of 9 commits - do you want me to squash them down? |
Signed-off-by: Christian König <[email protected]>
Regarding the |
I have no problem with including this change even if it does not have the same aim as this PR. However, I don't know which "PR-rule" this project prefers: I'm used to "One PR does one thing". But happy to here from reviewers/maintainers. |
Thanks a lot for your work on this! Generally we prefer "isolated" PRs. To me this PR fits just fine: it's all about a Let me know when you are "done" for a final review or need some help anywhere. |
I think I'm done :-) __
Only what's necessary to resolve the errors resulting from the changes made in the dependencies. |
What errors are those? The CI passes? Sorry if I sound redundant -- I am not super active here anymore so am not following all discussions, but want to keep this project breathing anyway. |
The CI passes with all changes I made. But as I wrote in my PR description, some dependencies are not updated, because they will cause compilation errors. (They do not occur in this PR as I did not updated those).
|
Ah OK! So I'll merge this then 👍 If you want any help on the others, feel free to continue on Gitter, or maybe even open a draft PR here with the compiling errors in so others can help you out. Thanks for your effort! |
I used
cargo-udeps
from here to scan for unused dependencies. Two package were removed,num
andglob
.With
cargo upgrades
from here I scanned for upgradable dependencies in theCagro.toml
files. I updated them (and regenerated theCargo.lock
) execept ofbecause they require changes to the code beyond my rust knowledge. I tracked them down as far as I could - hopefully someone else can continue here:
vergen
does not have thevergen::Config
structure since 8.0 anymore, but usesvergen::EmitBuilder
now.rsa
does not have thehash
module anymore since 0.7.0, but usesOIDs
base64
changedencode*
anddecode*
top level functions to methods ofengine
since 0.20quick-xml
failed with a few compiling errors