[beken-72xx] Fix race condition when checking Wi-Fi SSID #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be the race between the event RW_EVT_STA_CONNECTED and an actual valid SSID value returned by BDK. If even a small delay is injected immediately after the event reception the valid value becomes available. Without this fix, due to a polling nature of ESPHome WiFiComponent::check_connecting_finished function may observe the WiFiSTAConnectStatus::CONNECTED status but with an empty SSID value, leading to `Incomplete connection.` warning and immediate attempt to start another connection, while the current one was actually established.
|
Sorry, my bad. Wasn't aware about |
kuba2k2
added
bug
kuba2k2
reviewed
Apr 8, 2024
kuba2k2
approved these changes
Apr 8, 2024
szupi-ipuzs
reviewed
Apr 15, 2024
Cossid
reviewed
Apr 19, 2024
Cossid
approved these changes
Apr 19, 2024
Co-authored-by: Cossid <[email protected]>
kuba2k2
approved these changes
Apr 19, 2024
kuba2k2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be the race between the event
RW_EVT_STA_CONNECTEDand an actual valid SSID value returned by BDK. If even a small delay is injected immediately after the event reception the valid value becomes available. Without this fix, due to a polling nature ofESPHome WiFiComponent::check_connecting_finishedfunction may observe theWiFiSTAConnectStatus::CONNECTEDstatus but with an empty SSID value, leading toIncomplete connection.warning and immediate attempt to start another connection, while the current one was actually established.