Ultrawide support #259

AngheloAlf · 2020-09-16T17:29:42Z

Hi!

This change adds support for 64:27 aspect ratio, oftenly labeled as 21:9 as a marketing term.

Add the 64:27 adjusted option to the Aspect Ratio in-menu option, and adds a 64:27 Resolution in-menu option to let the user select the resolution for this aspect ratio.

Some comparison screenshots:

Aspect ratio	Title screen screenshot	Lon lon ranch screenshot
4:3
16:9
64:27

More comparison screenshots can be seen here.

Tested on RetroArch 1.9.0, Pop!_OS 20.04, using a Zelda OoT randomized rom.

According to [Wikipedia](https://wikipedia.org/wiki/21:9_aspect_ratio) 21:9 is just a marketing term. The real aspect ratio I wanted is 64:27, so terminology was changed accordingly. A few messages were added to explain this to the final user.

m4xw · 2020-09-16T18:01:51Z

I dont like this PR (and its not your fault).
This will need to be implemented differently but I am not entirely sure how I want it either, so give me a few days to think about it!
I am def. open for adding this - so keep the PR open for reference

m4xw · 2020-09-16T18:03:12Z

Also btw a change like 043c679 would need to happen upstream

AngheloAlf · 2020-09-16T19:01:08Z

I also think that this should be implemented differently, but I tried make the change respecting the way it was already implemented.

Also btw a change like 043c679 would need to happen upstream

Oh, you're right, I'll see what can I do there.

m4xw · 2020-09-16T19:52:12Z

I also think that this should be implemented differently, but I tried make the change respecting the way it was already implemented.

Ye, I noticed that ;)
My pain limit for resolution selectors is 2 tho 🙈

AngheloAlf · 2020-09-17T00:40:42Z

My pain limit for resolution selectors is 2 tho 🙈

And what about just leaving a "4:3 Resolution" selector and a Widescreen Resolution selector?

The Widescreen Resolution selector would have all the resolutions for 16:9 and 64:27. It could even include other weirds aspect ratios.

The Aspect Ratio selector would only have 3 options. The option Widescreen adjusted would calculate the aspect ratio based on the selected Widescreen resolution. The other options would force the corresponding aspect ratio.

Add resolutions other than 16:9 to this option, specifying the aspect ratio on it's label. Also change "16:9 adjusted" for "Widescreen adjusted" in the "Aspect ratio" setting. Selecting this will infer the aspect ratio based on the selected widescreen resolution.

m4xw · 2020-09-21T09:55:07Z

I like that more, Will gather some opinions

m4xw · 2020-09-29T09:57:00Z

We should keep backwards compat here for now, can remove it later after most of the users saved their config after the deployment

AngheloAlf · 2020-10-03T19:12:34Z

Something like this? I undid the settings change, so it has the same options, but it still provides compatibility with wider screens.

m4xw · 2020-10-05T09:45:27Z

Not sure about ,'s, but I am no native speaker

Will check the rest when I find some time

AngheloAlf · 2020-10-14T22:05:25Z

I think they are correct, but I can remove them if you prefer it.

m4xw · 2020-10-16T10:00:37Z

I think they are correct, but I can remove them if you prefer it.

Yea please do i think they ruin the pacing of the sentence.

AngheloAlf · 2020-10-16T17:05:29Z

Done. Do you suggest any more changes?

m4xw

This should be good to go otherwise, I will push it to a branch tomorrow and let a few ppl test. if all works out I will merge.
Not sure if i missed some behaviour.

libretro/libretro_core_options.h

libretro/libretro.c

AngheloAlf · 2020-10-19T18:30:20Z

Done both changed. Anything else?

libretro/libretro_core_options.h

m4xw

See topic

libretro/libretro.c

m4xw · 2020-10-21T11:05:07Z

Did a gliden rebase that I am gonna push later and also added this PR on top of it on a branch https://git.libretro.com/libretro/mupen64plus-libretro-nx/-/pipelines/2831
Can you check if those builds work out for you? I will have it tested rn as well

AngheloAlf · 2020-10-21T18:09:24Z

Can you check if those builds work out for you? I will have it tested rn as well

I tested the artifact in that page, and also I compiled and tested that code myself in my machine, just to be sure. Both works without problems for me.

m4xw · 2020-10-21T18:40:26Z

@AngheloAlf a bug i found, if you select 16:9 aspect (non adjusted) you dont calculate the aspect ratio leading to a 4:3 like image output

This is directly dependent.
For now we can change the display name of the options without changing the config value (will be confusing but i eventually write about it in a blog post)

https://git.libretro.com/libretro/mupen64plus-libretro-nx/-/blob/develop/libretro/libretro_core_options.h#L134-139
the null's -> "Widescreen", "Widescreen (Adjusted)", leave 4:3, dont touch the left value.

All the settings I have hooked up under the hood so u just need to set it right (as you found out ;-))
So we can just calc it for 2 || 3, I know stretched isnt so insteresting for ultra wide, but I might just add a few other odd ones in the future, so i like to keep that open

AngheloAlf · 2020-10-22T18:37:14Z

@AngheloAlf a bug i found, if you select 16:9 aspect (non adjusted) you dont calculate the aspect ratio leading to a 4:3 like image output

That's weird, it should be calculated here:

Anyway, I'll look up what's the problem.

This is directly dependent.
For now we can change the display name of the options without changing the config value (will be confusing but i eventually write about it in a blog post)

https://git.libretro.com/libretro/mupen64plus-libretro-nx/-/blob/develop/libretro/libretro_core_options.h#L134-139
the null's -> "Widescreen", "Widescreen (Adjusted)", leave 4:3, dont touch the left value.

Yeah, you're right. I don't know how I didn't think about that. I'll change it.

Note, you also want to test the native res factor behaviour, aspect still applies

I have been playing with this enabled (6x I think) with no problem, but I'll test it anyway and look up for some side effect.

Another note, use cached interpreter if u want to play randomizer ;)

Oh. Why? I thought the cached interpreter were slower. I remember reading somewhere about changing the TLB exceptions option when playing rando, so I'll look up that option too. Thanks

m4xw · 2020-10-22T18:51:32Z

That's weird, it should be calculated here:

Thats 16:9 tho and its a ultrawide resolution ;)

Dont forget this is the "wide" option yet, so we need to calc it.

Oh. Why? I thought the cached interpreter were slower. I remember reading somewhere about changing the TLB exceptions option when playing rando, so I'll look up that option too. Thanks

On PC? Shouldnt be significant and yea, because of the dynarec Issues, the TLB option is just a hack so you can basically save & restart (read: close content and start, otherwise it wont fix itself)

m4xw · 2020-10-22T18:57:34Z

Btw for reference, this is the libretro aspect ratio.
The "AspectRatio" key (1, 2, 3) is set here in GLideN64 https://github.com/libretro/mupen64plus-libretro-nx/blob/develop/custom/GLideN64/mupenplus/Config_mupenplus.cpp#L137
Its enforced here:

mupen64plus-libretro-nx/GLideN64/src/DisplayWindow.cpp

Line 136 in 8a92a86

void DisplayWindow::_setBufferSize()

So my suggestion now is remove the "forced 16:9" (== 2) and replace with "Stretch" (== 0), as seen here

mupen64plus-libretro-nx/GLideN64/src/Config.h

Lines 94 to 100 in 8a92a86

    
           enum Aspect { 
        
           	aStretch = 0, 
        
           	a43 = 1, 
        
           	a169 = 2, 
        
           	aAdjust = 3, 
        
           	aTotal = 4 
        
           };

Keep 4:3 what it is and then keep how it is for "adjusted"

AngheloAlf · 2020-10-22T19:16:26Z

@AngheloAlf a bug i found, if you select 16:9 aspect (non adjusted) you dont calculate the aspect ratio leading to a 4:3 like image output
That's a weird bug. With that aspect selected, choosing a 16:9 resolution stretches it to 16:9 as expected, but selecting a wider one renders the game at 4:3.

For visual reference, this is how I see the game in "16:9" aspect ratio with "1920x1080" selected:

And this is how I see it with that same aspect ratio, but with "2560x1080" selected:

Btw for reference, this is the libretro aspect ratio.
The "AspectRatio" key (1, 2, 3) is set here in GLideN64 https://github.com/libretro/mupen64plus-libretro-nx/blob/develop/custom/GLideN64/mupenplus/Config_mupenplus.cpp#L137
Its enforced here:

mupen64plus-libretro-nx/GLideN64/src/DisplayWindow.cpp

Line 136 in 8a92a86

void DisplayWindow::_setBufferSize()

So my suggestion now is remove the "forced 16:9" (== 2) and replace with "Stretch" (== 0), as seen here

mupen64plus-libretro-nx/GLideN64/src/Config.h

Lines 94 to 100 in 8a92a86

enum Aspect {

aStretch = 0,

a43 = 1,

a169 = 2,

aAdjust = 3,

aTotal = 4

};

Keep 4:3 what it is and then keep how it is for "adjusted"

That could explain the problem. I'll test that in a moment.

m4xw · 2020-10-22T19:18:56Z

Also might as well call "16:9" now "Wide (Stretched)"

m4xw · 2020-10-22T19:26:40Z

Also I guess it might be confusing with how it was named before for you, but 16:9 always meant set resolution, stretched and adjusted always means widescreen hack.
It was just a side effect of having seperate core options for it :P
If people really need such behaviour, i need to add a "fit" mode

AngheloAlf · 2020-10-22T19:42:44Z

You were right, now the stretched option works "as intended"

It's weird playing with the image so stretched, but maybe somebody likes it (?).

Also might as well call "16:9" now "Wide (Stretched)"

Yeah, I was thinking something like that too.
Also, what about renaming "4:3" to "Original (4:3)"?

AngheloAlf · 2020-10-22T19:47:14Z

Also I guess it might be confusing with how it was named before for you, but 16:9 always meant set resolution, stretched and adjusted always means widescreen hack.
It was just a side effect of having seperate core options for it :P
If people really need such behaviour, i need to add a "fit" mode

A bit 😅. I think the naming was fine if we only consider there were mainly two aspect ratios.

m4xw · 2020-10-22T20:04:41Z

Scaling the aspect ratio further would be frontend business IMO. (Instead of "Core provided" in RA)
Thats why stretch exists, also for perf gains on 16:9

m4xw · 2020-10-22T20:05:31Z

But why someone would use it with ultrawide... good question xD

m4xw · 2020-10-22T20:09:28Z

https://git.libretro.com/libretro/mupen64plus-libretro-nx/-/pipelines/2879/builds

AngheloAlf · 2020-10-22T20:24:31Z

https://git.libretro.com/libretro/mupen64plus-libretro-nx/-/pipelines/2879/builds

Works with no issues for me (both artifact and compiling myself).

m4xw · 2020-10-22T20:33:16Z

There can be a few nits for documentation that i can think of, like annotating the types i quoted but this looks good to me and testing passes.
Ready to go?

AngheloAlf · 2020-10-22T20:50:40Z

There can be a few nits for documentation that i can think of, like annotating the types i quoted but this looks good to me and testing passes.

By annotating the types, you mean change some magic numbers for something less "magic"?

For example, use this enum:

mupen64plus-libretro-nx/GLideN64/src/Config.h

Lines 94 to 100 in 8a92a86

    
           enum Aspect { 
        
           	aStretch = 0, 
        
           	a43 = 1, 
        
           	a169 = 2, 
        
           	aAdjust = 3, 
        
           	aTotal = 4 
        
           };

Like this:

(i know it wont work because it is c++ code, but that is the idea)

Ready to go?

Besides that detail, I think I'm ready.

m4xw · 2020-10-22T20:53:46Z

Yes, just // Aspect::aStretch, i do that somewhere else already iirc..
Still hesitant to make libretro.c cpp :P

AngheloAlf · 2020-10-22T21:02:36Z

Yes, just // Aspect::aStretch, i do that somewhere else already iirc..

Like this?

(edit: i just realized i missed a = in the first if. ups)

Still hesitant to make libretro.c cpp :P

I think its fine like it is right now.

m4xw · 2020-10-22T21:07:55Z

Remove the Config::

AngheloAlf · 2020-10-22T21:10:31Z

Ups. Fixed 😅

m4xw

If this backfires, blame the beer :P

m4xw · 2020-10-22T21:12:47Z

Thanks for this

AngheloAlf · 2020-10-22T21:17:12Z

Thanks for this

Thanks to you!
It was a great team work.

Have a great day :3

m4xw · 2020-10-23T21:15:09Z

@AngheloAlf I totally forgot, the stretch thing is to support widescreen via game patches ;)

AngheloAlf · 2020-10-23T21:34:50Z

@AngheloAlf I totally forgot, the stretch thing is to support widescreen via game patches ;)

Ohh, that make sense.
Now that you mention it, I think DK64 has widescreen support built-in, so the player had to stretch the image in the tv options.
I wonder if other games have that option too 🤔

Jj0YzL5nvJ · 2020-10-24T21:57:51Z

I wonder if other games have that option too 🤔

http://www.gamepilgrimage.com/content/games-widescreen-support-standard-definition
https://youtu.be/eM16F_dM1Js
https://youtu.be/VA1H6dw6Fxo

AngheloAlf added 3 commits September 16, 2020 11:43

Add 21:9 support

01fa29f

Improve readability of a teernary conditional

1c7a06f

Change 21:9 to 64:27

043c679

According to [Wikipedia](https://wikipedia.org/wiki/21:9_aspect_ratio) 21:9 is just a marketing term. The real aspect ratio I wanted is 64:27, so terminology was changed accordingly. A few messages were added to explain this to the final user.

Undo GLideN64 change, keeping the 64:27 support

b2a7661

Keep backwards compat with current settings file

5c74ce6

Remove commas in aspect ratio description

8ad1eb5

m4xw requested changes Oct 16, 2020

View reviewed changes

libretro/libretro_core_options.h Outdated Show resolved Hide resolved

libretro/libretro.c Outdated Show resolved Hide resolved

Change "16:9 Resolution" to "Wide Resolution" and no triple /

c58da0c

m4xw reviewed Oct 20, 2020

View reviewed changes

libretro/libretro_core_options.h Outdated Show resolved Hide resolved

AngheloAlf added 2 commits October 20, 2020 10:36

Add comment explaining why config key wasn't changed

7e90366

Small comment changes

3ede6de

m4xw requested changes Oct 20, 2020

View reviewed changes

libretro/libretro.c Outdated Show resolved Hide resolved

make screen_size_key static and give it a default value

1d15a57

Rename aspect ratio options and fix the stretch option

2a8961a

m4xw approved these changes Oct 22, 2020

View reviewed changes

Comment annotate AspectRatio

96b3347

Forgot to erase Config::

09cc4e0

m4xw approved these changes Oct 22, 2020

View reviewed changes

m4xw merged commit 0052b9e into libretro:develop Oct 22, 2020

m4xw mentioned this pull request Nov 7, 2024

Unable to See 32:9 Resolutions, and 21:9 Resolutions Showing as 64:27 in mupen64plus-libretro-nx via RetroArch on a 32:9 Monitor #555

Open

Ultrawide support #259

Ultrawide support #259

Conversation

AngheloAlf commented Sep 16, 2020

m4xw commented Sep 16, 2020

m4xw commented Sep 16, 2020

AngheloAlf commented Sep 16, 2020

m4xw commented Sep 16, 2020

AngheloAlf commented Sep 17, 2020

m4xw commented Sep 21, 2020

m4xw commented Sep 29, 2020

AngheloAlf commented Oct 3, 2020

m4xw commented Oct 5, 2020

AngheloAlf commented Oct 14, 2020

m4xw commented Oct 16, 2020

AngheloAlf commented Oct 16, 2020

m4xw left a comment

Choose a reason for hiding this comment

AngheloAlf commented Oct 19, 2020

m4xw left a comment

Choose a reason for hiding this comment

m4xw commented Oct 21, 2020

AngheloAlf commented Oct 21, 2020

m4xw commented Oct 21, 2020

AngheloAlf commented Oct 22, 2020

m4xw commented Oct 22, 2020

m4xw commented Oct 22, 2020 • edited Loading

AngheloAlf commented Oct 22, 2020

m4xw commented Oct 22, 2020

m4xw commented Oct 22, 2020 • edited Loading

AngheloAlf commented Oct 22, 2020

AngheloAlf commented Oct 22, 2020

m4xw commented Oct 22, 2020

m4xw commented Oct 22, 2020

m4xw commented Oct 22, 2020

AngheloAlf commented Oct 22, 2020

m4xw commented Oct 22, 2020

AngheloAlf commented Oct 22, 2020 • edited Loading

m4xw commented Oct 22, 2020 • edited Loading

AngheloAlf commented Oct 22, 2020 • edited Loading

m4xw commented Oct 22, 2020

AngheloAlf commented Oct 22, 2020

m4xw left a comment

Choose a reason for hiding this comment

m4xw commented Oct 22, 2020

AngheloAlf commented Oct 22, 2020

m4xw commented Oct 23, 2020

AngheloAlf commented Oct 23, 2020 • edited Loading

Jj0YzL5nvJ commented Oct 24, 2020

m4xw commented Oct 22, 2020 •

edited

Loading

m4xw commented Oct 22, 2020 •

edited

Loading

AngheloAlf commented Oct 22, 2020 •

edited

Loading

m4xw commented Oct 22, 2020 •

edited

Loading

AngheloAlf commented Oct 22, 2020 •

edited

Loading

AngheloAlf commented Oct 23, 2020 •

edited

Loading