Fix failing tests

Reflects new role for expanded codemirror editor
libris · Dec 21, 2024 · 91ad6cd · 91ad6cd
1 parent fd85aa1
commit 91ad6cd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/supersearch/e2e/supersearch.spec.ts b/packages/supersearch/e2e/supersearch.spec.ts
@@ -73,18 +73,20 @@ test('syncs collapsed and expanded editor views', async ({ page }) => {
 	await page
 		.locator('[data-test-id="test1"]')
 		.getByRole('dialog')
-		.getByRole('textbox')
+		.getByRole('combobox')
 		.locator('div')
 		.fill('Hello world');
 	await page
 		.locator('[data-test-id="test1"]')
 		.getByRole('dialog')
-		.getByRole('textbox')
+		.getByRole('combobox')
+		.locator('div')
 		.selectText();
 	await page
 		.locator('[data-test-id="test1"]')
 		.getByRole('dialog')
-		.getByRole('textbox')
+		.getByRole('combobox')
+		.locator('div')
 		.press('Escape');
 	await expect(
 		await page.locator('[data-test-id="test1"]').getByRole('textbox').locator('div'),
@@ -101,7 +103,7 @@ test('fetches and displays paginated results', async ({ page }) => {
 	await page
 		.locator('[data-test-id="test1"]')
 		.getByRole('dialog')
-		.getByRole('textbox')
+		.getByRole('combobox')
 		.locator('div')
 		.fill('Hello');
 	await expect(page.locator('[data-test-id="result-item"]').first()).toContainText('Heading 1');

diff --git a/packages/supersearch/src/routes/+page.svelte b/packages/supersearch/src/routes/+page.svelte
@@ -84,6 +84,7 @@
 	<fieldset data-test-id="test2">
 		<legend>Supersearch using <code>form</code> attribute</legend>
 		<SuperSearch
+			id="supersearch-using-form-attribute"
 			name="q"
 			bind:value={value2}
 			{placeholder}