fix(supersearch): Implement the _Invalid type (LWS-287) #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesperengstrom
changed the title
johanbissemattsson
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LWS-287
Description
Solves
With libris/librisxl#1541, we now have a way to decisively say a property is invalid, and can have the red squiggly line to mean that, not just that no label was found for it.
This can so far only be tested with dev backend.
Summary of changes
@type: '_Invalid'as a new keyinvalidto the frontend. UpdateDisplayMappingtype accordingly.GetLabelFunction, matchinvalidfor a certain key and return an invalid boolean.invalid.