feat(supersearch): Insert space before qualifier (LWS-286) #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesperengstrom
changed the title
packages/supersearch/src/lib/extensions/lxlQualifierPlugin/insertSpace.ts
Outdated
Show resolved
Hide resolved
packages/supersearch/src/lib/extensions/lxlQualifierPlugin/insertSpace.ts
Outdated
Show resolved
Hide resolved
johanbissemattsson
approved these changes
Jan 15, 2025
jesperengstrom
deleted the
fix-supersearch-insert-space-before-qualifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tickets involved
LWS-286
Solves
Avoids breaking a qualifier pill by typing stuff before it, inadvertently altering the
qualifierKey.Summary of changes
insertSpaceBeforeQualifierfunction with the plugin - a transaction filter that checks if any atomic range overlaps the cursor position. If so, add a blank space at the position (before the pill).RangeSetBuilder. This can then be passed directly toEditorview.atomicRangesand the insertSpace functions, and previous workarounds (atomicprop,filterAtomicfunction are no longer needed).