feat(lxl-web): Add debug mode for relevancy scoring #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olovy
requested review from
johanbissemattsson,
jesperengstrom,
lrosenstrom and
kwahlin
olovy
force-pushed
the
feature/LWS-296-debug-scoring
branch
from
d392eb5 to
132d464
Compare
| @@ -16,8 +17,10 @@ export const load = async ({ params, url, locals, fetch }) => { | |||
| redirect(303, `/`); // redirect to home page if no search params are given | |||
| } | |||
|
|
|||
| const debug = locals.userSettings?.debug.includes(DebugFlags.ES_SCORE) ? '&_debug=esScore' : ''; | |||
There was a problem hiding this comment.
This is what's causing the test to fail.
Try changing it to
const debug = locals.userSettings?.debug?.includes(DebugFlags.ES_SCORE) ? '&_debug=esScore' : '';
There was a problem hiding this comment.
Because: the test in question is changing the facet sorting, and thereby creating a settings cookie in userSettings. So it has locals.userSettings but not debug.
There was a problem hiding this comment.
Yes! That was it. Missed it when changing it from a boolean to an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add debug mode for relevancy scoring.
?_debug=esScore, disable with?_debug=falseTickets involved
LWS-296