Tweaks to satisfy RuboCop Performance 1.8.0 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/rubocop-hq/rubocop-performance/releases/tag/v1.8.0 Performance/CollectionLiteralInLoop caught some instances in tests. Not all that important, but why not make tests use a tiny bit less memory... Note one of the changes, that in spec/integration_spec.rb doesn't actually allocate less, it just naively satisfies the cop. Actually moving the declaration outside of the loop would move it way far from use and be less readable IMO.
benbalter
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rubocop-hq/rubocop-performance/releases/tag/v1.8.0
Performance/CollectionLiteralInLoop caught some instances in tests.
Not all that important, but why not make tests use a tiny bit less
memory...
Note one of the changes, that in spec/integration_spec.rb doesn't
actually allocate less, it just naively satisfies the cop. Actually
moving the declaration outside of the loop would move it way far
from use and be less readable IMO.