Remove gap between bottom clock and board on mobile #16920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to remove the small gap between the bottom clock and the board.
johndoknjas
force-pushed
the
mobile-clock-spacing
branch
2 times, most recently
from
7c8a2d7 to
e84af81
Compare
johndoknjas
force-pushed
the
mobile-clock-spacing
branch
from
9040ebc to
e09ab2c
Compare
|
The gap size depends on the screen width, because the board must be square, and its size must be a multiple of 8px in order to avoid rendering issues on many browsers/devices. It's true for each and every board displayed on the website. Hardcoding any margin (like 3px) will only work on your precise screen resolution.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shifts the bottom clock up by 3 pixels (on mobile in vertical mode) in order to remove the gap between it and the chessboard.
Also, the PR shouldn't change the relative positioning of the clock numbers within their clock, but I can't really tell for sure for the bottom clock (see screenshots below).
Before (with both clocks in green to show positioning):
After:
