Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMT-4. Not relevant comments #385

Closed
folkyatina opened this issue Jan 18, 2022 · 0 comments
Closed

CMT-4. Not relevant comments #385

folkyatina opened this issue Jan 18, 2022 · 0 comments
Assignees
@folkyatina
Labels
audit Issue comes as a result of an external audit cosmetic solidity issues/tasks related to smart contract code

Comments

@folkyatina
Copy link
Member

At the lines:

https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.8.9/DepositSecurityModule.sol#L190
https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.8.9/DepositSecurityModule.sol#L197
https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.8.9/DepositSecurityModule.sol#L389
in the comment have a reference to the variable MIN_DEPOSIT_BLOCK_DISTANCE.
However, this variable is not defined anywhere.
@folkyatina folkyatina added cosmetic solidity issues/tasks related to smart contract code audit Issue comes as a result of an external audit labels Jan 18, 2022
@folkyatina folkyatina self-assigned this Jan 18, 2022
folkyatina pushed a commit that referenced this issue Jan 19, 2022
Fix comments not to mention non-existent constants. Fix #385
638a9c2
@arwer13 arwer13 closed this as completed May 18, 2022
RayLvv pushed a commit to okx-dao/lido-dao that referenced this issue Dec 12, 2022
Fix comments not to mention non-existent constants. Fix lidofinance#385
44f9c53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@folkyatina folkyatina

Labels
audit Issue comes as a result of an external audit cosmetic solidity issues/tasks related to smart contract code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@folkyatina @arwer13