Fix: review/mev lips round2 #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are misleading from the off-chain perspective.
refactor: rename withdrawal limit points to withdrawal limit for consistency
Add more meaningful API for staking limits Rename STAKING_PAUSE_ROLE to STAKING_CONTROL_ROLE [skip ci] Tests needs to be updated
update stake limit tests
RayLvv
pushed a commit
to okx-dao/lido-dao
that referenced
this pull request
Dec 12, 2022
…ound2 Fix: review/mev lips round2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for the second review round.