Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare environment for further ET deployments #300

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Prepare environment for further ET deployments #300

merged 5 commits into from
Dec 22, 2023

Conversation

zuzueeka
Copy link
Contributor

  1. Add template with structure for ET payment setup addresses
  2. Add Sandbox setup for stables addresses (contracts were deployed by @bulbozaur), deployment tx: https://holesky.etherscan.io/tx/0x1317683f5559873be95aab298cd4bd2584468075082f9a1b2e9c037a9b329946
  3. Add Stables addresses (contracts were deployed by @bulbozaur), used for allowedTokensRegistry
  4. Add DAO-ops & QA ms (planned to be used as a trustCaller for payment setups)

@zuzueeka zuzueeka requested a review from a team as a code owner December 21, 2023 11:39
TheDZhon
TheDZhon reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the proposed layout 👍

though can't approve without the complete address set.

TheDZhon
TheDZhon reviewed Dec 21, 2023
View reviewed changes
docs/deployed-contracts/holesky.md Outdated Show resolved Hide resolved
docs/deployed-contracts/holesky.md Outdated Show resolved Hide resolved
bulbozaur
bulbozaur approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@bulbozaur bulbozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zuzueeka zuzueeka merged commit d2ce70b into main Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon left review comments

@bulbozaur bulbozaur bulbozaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zuzueeka @bulbozaur @TheDZhon