Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github link in docusaurus.config.js #519

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Sven-NOM
Copy link
Contributor

@Sven-NOM Sven-NOM commented Feb 5, 2025

This seems to get used in a bunch of headers on every docs page, and links to the old lidofinance.github.com.

This seems to get used in a bunch of headers on every docs page, and links to the old lidofinance.github.com.
@Sven-NOM Sven-NOM requested a review from a team as a code owner February 5, 2025 12:47
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GM, thank you for the contribution 🫡

Unfortunately, the suggested changes break the build as you can see from the CI report, so please consider getting it back in order 🙏

Fixed seperation of url and baseUrl
@Sven-NOM
Copy link
Contributor Author

Sven-NOM commented Feb 6, 2025

Thanks for the heads-up sir! The check in the CI report was very helpful. Splitting the url up in a url and baseUrl does the trick. Checked it locally first this time as well, so should be good this time.

@TheDZhon
Copy link
Contributor

TheDZhon commented Feb 6, 2025

ty ty!

@TheDZhon TheDZhon merged commit 7532e29 into lidofinance:main Feb 6, 2025
1 check passed
@TheDZhon
Copy link
Contributor

TheDZhon commented Feb 6, 2025

@Sven-NOM sorry, it still breaks the site, reverted the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants