eslint fixes

commitlint.config.js

@@ -1 +1,2 @@
+/* eslint-disable */
 module.exports = { extends: ["@commitlint/config-conventional"] };

src/command-utils.ts

@@ -1,5 +1,5 @@
-import { spawnSync } from "child_process";
 import chalk from "chalk";
+import { spawnSync } from "child_process";
 
 export function runCommand({
   command,

src/deploy-all-contracts.ts

@@ -1,11 +1,13 @@
 import { cpSync, readFileSync } from "node:fs";
 import process from "node:process";
+
+import chalk from "chalk";
 import dotenv from "dotenv";
-import env from "./env";
 import { ethers } from 'ethers';
-import { NetworkType } from "./rpc-utils";
+
 import { runCommand } from "./command-utils";
-import chalk from "chalk";
+import env from "./env";
+import { NetworkType } from "./rpc-utils";
 
 export async function burnL2DeployerNonces(l2RpcUrl: string, numNonces: number) {
   const l2Provider = new ethers.JsonRpcProvider(l2RpcUrl);

src/deploy-gov-executor.ts

@@ -1,11 +1,23 @@
-import { writeFileSync, readFileSync } from "node:fs";
+import { readFileSync,writeFileSync } from "node:fs";
+
 import chalk from "chalk";
 import { ethers } from "ethers";
+
 import env from "./env";
 
 const GOV_BRIDGE_EXECUTOR_PATH = "./governance-crosschain-bridges/artifacts/contracts/bridges/OptimismBridgeExecutor.sol/OptimismBridgeExecutor.json";
 const MAX_DEPLOYMENT_TRIES = 3;
 
+type ConstructorArgs = [
+  string, // ovmL2Messenger
+  string, // ethereumGovExecutor
+  number, // delay
+  number, // gracePeriod
+  number, // minDelay
+  number, // maxDelay
+  string  // ovmGuiardian
+];
+
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export async function deployGovExecutor(deploymentConfig: any, rpcUrl: string) {
   const contractJson = JSON.parse(
@@ -17,7 +29,8 @@ export async function deployGovExecutor(deploymentConfig: any, rpcUrl: string) {
   const { abi, bytecode } = contractJson;
   const provider = new ethers.JsonRpcProvider(rpcUrl);
   const wallet = new ethers.Wallet(env.string("DEPLOYER_PRIVATE_KEY"), provider);
-  const contractFactory = new ethers.ContractFactory(abi, bytecode, wallet);
+
+  const contractFactory = new ethers.ContractFactory<ConstructorArgs, ethers.BaseContract>(abi, bytecode, wallet);
 
   const govBridgeExecutorConfig = deploymentConfig["l2"]["govBridgeExecutor"];
   const contract = await deploy(contractFactory, govBridgeExecutorConfig, 1);
@@ -30,7 +43,7 @@ export async function deployGovExecutor(deploymentConfig: any, rpcUrl: string) {
   return deployedContractAddress;
 }
 
-async function deploy(contractFactory: ethers.ContractFactory<any[], ethers.BaseContract>, govBridgeExecutorConfig: Record<string, any>, tryIndex: number) {
+async function deploy(contractFactory: ethers.ContractFactory<ConstructorArgs, ethers.BaseContract>, govBridgeExecutorConfig: Record<string, string | number>, tryIndex: number) {
   console.log(
     chalk.bold(
       chalk.yellowBright(
@@ -41,13 +54,13 @@ async function deploy(contractFactory: ethers.ContractFactory<any[], ethers.Base
 
   try {
       const contract = await contractFactory.deploy(
-        govBridgeExecutorConfig["ovmL2Messenger"],
-        govBridgeExecutorConfig["ethereumGovExecutor"],
-        govBridgeExecutorConfig["delay"],
-        govBridgeExecutorConfig["gracePeriod"],
-        govBridgeExecutorConfig["minDelay"],
-        govBridgeExecutorConfig["maxDelay"],
-        govBridgeExecutorConfig["ovmGuiardian"],
+        govBridgeExecutorConfig["ovmL2Messenger"] as string,
+        govBridgeExecutorConfig["ethereumGovExecutor"] as string,
+        govBridgeExecutorConfig["delay"] as number,
+        govBridgeExecutorConfig["gracePeriod"] as number,
+        govBridgeExecutorConfig["minDelay"] as number,
+        govBridgeExecutorConfig["maxDelay"] as number,
+        govBridgeExecutorConfig["ovmGuiardian"] as string,
       );
       await contract.deploymentTransaction();
       return contract;
@@ -79,9 +92,9 @@ export function saveGovExecutorDeploymentArgs(contractAddress: string, deploymen
   writeFileSync(`./artifacts/${fileName}`, JSON.stringify(content, null, 2));
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
+ 
 export function addGovExecutorToDeploymentArtifacts(govBridgeExecutor: string, deploymentResultsFilename: string) {
-  let newContractsConfig = configFromArtifacts(deploymentResultsFilename);
+  const newContractsConfig = configFromArtifacts(deploymentResultsFilename);
   newContractsConfig["optimism"]["govBridgeExecutor"] = govBridgeExecutor;
   writeFileSync(`./artifacts/${deploymentResultsFilename}`, JSON.stringify(newContractsConfig, null, 2));
 }

src/diffyscan.ts

@@ -1,7 +1,9 @@
 import { readFileSync, writeFileSync} from "node:fs";
 import process from "node:process";
-import { runCommand } from "./command-utils";
+
 import dotenv from "dotenv";
+
+import { runCommand } from "./command-utils";
 import env from "./env";
 
 const UNICHAIN_CONFIGS_PATH = "./diffyscan/config_samples/optimism/automaton";

src/env.ts

@@ -26,6 +26,7 @@ function isValidUrl(envValue: string) {
   try {
     new URL(envValue);
     return true;
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
   } catch (_) {
     return false;
   }

src/integration-tests.ts

@@ -1,4 +1,5 @@
 import dotenv from "dotenv";
+
 import { runCommand } from "./command-utils";
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any

src/main.ts

@@ -3,27 +3,26 @@ import * as child_process from "node:child_process";
 import fs from "node:fs";
 import path from "node:path";
 import process from "node:process";
-import env from "./env";
 
 import "dotenv/config";
 import { program } from "commander";
 import { JsonRpcProvider } from "ethers";
 import { once } from "stream";
 import * as YAML from "yaml";
 
-import { runDiffyscanScript, setupDiffyscan } from "./diffyscan";
-import { addGovExecutorToDeploymentArtifacts, deployGovExecutor, saveGovExecutorDeploymentArgs } from "./deploy-gov-executor";
 import {
   burnL2DeployerNonces,
   configFromArtifacts,
+  copyArtifacts,
   populateDeployScriptEnvs,
-  runDeployScript,
-  copyArtifacts
-} from "./deploy-all-contracts";
+  runDeployScript} from "./deploy-all-contracts";
+import { addGovExecutorToDeploymentArtifacts, deployGovExecutor, saveGovExecutorDeploymentArgs } from "./deploy-gov-executor";
+import { runDiffyscanScript, setupDiffyscan } from "./diffyscan";
+import env from "./env";
+import { runIntegrationTestsScript,setupIntegrationTests } from "./integration-tests";
+import { diffyscanRpcUrl,l1RpcUrl, l2RpcUrl, localL1RpcPort, localL2RpcPort, NetworkType } from "./rpc-utils";
 import { runStateMateScript, setupStateMateConfig, setupStateMateEnvs } from "./state-mate";
 import { runVerificationScript, setupGovExecutorVerification } from "./verification";
-import { setupIntegrationTests, runIntegrationTestsScript } from "./integration-tests";
-import { NetworkType, l1RpcUrl, l2RpcUrl, localL1RpcPort, localL2RpcPort, diffyscanRpcUrl } from "./rpc-utils";
 
 const NUM_L1_DEPLOYED_CONTRACTS = 3;
 

src/state-mate.ts

@@ -4,6 +4,7 @@ import process from "node:process";
 import dotenv from "dotenv";
 import { ethers } from "ethers";
 import * as YAML from "yaml";
+
 import { runCommand } from "./command-utils";
 
 export function setupStateMateEnvs(ethereumRpcUrl: string, optimismRpcUrl: string) {
@@ -135,7 +136,7 @@ export function setupStateMateConfig(
   tokenRateOracleChecks.set("MIN_TIME_BETWEEN_TOKEN_RATE_UPDATES", Number(tokenRateOracleConfig["minTimeBetweenTokenRateUpdates"]));
   tokenRateOracleChecks.set("OLDEST_RATE_ALLOWED_IN_PAUSE_TIME_SPAN", Number(tokenRateOracleConfig["oldestRateAllowedInPauseTimeSpan"]));
   tokenRateOracleChecks.set("TOKEN_RATE_OUTDATED_DELAY", Number(tokenRateOracleConfig["tokenRateOutdatedDelay"]));
-  tokenRateOracleChecks.set("isTokenRateUpdatesPaused", !Boolean(tokenRateOracleConfig["updateEnabled"]));
+  tokenRateOracleChecks.set("isTokenRateUpdatesPaused", !tokenRateOracleConfig["updateEnabled"]);
 
   // L2TokenBridge
   const l2TokenBridge = l2Contracts.get("tokenBridge") as YAML.YAMLMap;
@@ -157,15 +158,15 @@ export function setupStateMateConfig(
     checks.set("eip712Domain", ["0x0f",name,version,l2ChainId,address,"0x0000000000000000000000000000000000000000000000000000000000000000",[]]);
   }
 
-  function domainSeparator(name: string, version: string, l2ChainId: number, addr: string) {
+  function domainSeparator(name: string, version: string, chainId: number, addr: string) {
     const hashedName = ethers.keccak256(ethers.toUtf8Bytes(name));
     const hashedVersion = ethers.keccak256(ethers.toUtf8Bytes(version));
     const typeHash = ethers.keccak256(
       ethers.toUtf8Bytes("EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)"),
     );
     const encodedParams = ethers.AbiCoder.defaultAbiCoder().encode(
       ["bytes32", "bytes32", "bytes32", "uint256", "address"],
-      [typeHash, hashedName, hashedVersion, l2ChainId, addr],
+      [typeHash, hashedName, hashedVersion, chainId, addr],
     );
     return ethers.keccak256(encodedParams);
   }  

src/verification.ts

@@ -1,6 +1,8 @@
+import { readFileSync } from "node:fs";
+
 import dotenv from "dotenv";
+
 import { runCommand } from "./command-utils";
-import { readFileSync } from "node:fs";
 import env from "./env";
 
 export function runVerificationScript({