Before Pectra voting script #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amuhar
force-pushed
the
feat/pectra-devnet
branch
from
1c40c6c to
c8501b8
Compare
AlexandrMov
reviewed
Jan 29, 2025
Co-authored-by: Alexander M <[email protected]>
Add a separate script for launching on Holesky and new vote items: - rotation of GateSeals - changing voting and objection time
avsetsin
reviewed
Feb 10, 2025
avsetsin
reviewed
Feb 18, 2025
| agent_forward([encode_cs_fee_oracle_set_consensus_version()]), | ||
| ), | ||
| ( | ||
| "9. Revoke MANAGE_CONSENSUS_VERSION_ROLE role on Validator Exit Bus Oracle from Aragon Agent", |
There was a problem hiding this comment.
Suggested change
| "9. Revoke MANAGE_CONSENSUS_VERSION_ROLE role on Validator Exit Bus Oracle from Aragon Agent", | |
| "9. Revoke MANAGE_CONSENSUS_VERSION_ROLE role on CSFeeOracle from Aragon Agent", |
| """ | ||
| Release part of the update before the Pectra upgrade | ||
|
|
||
| 1. Grant MANAGE_CONSENSUS_VERSION_ROLE role on Accounting Oracle to Aragon Agent |
There was a problem hiding this comment.
consider adding detailed description with addresses as it's done for non pectra items
Psirex
reviewed
Feb 18, 2025
| def _check_role(contract: Contract, role: str, holder: str): | ||
| role_bytes = web3.keccak(text=role).hex() | ||
| assert contract.getRoleMemberCount(role_bytes) == 1, f"Role {role} on {contract} should have exactly one holder" | ||
| assert contract.getRoleMember(role_bytes, 0) == holder, f"Role {role} holder on {contract} should be {holder}" |
There was a problem hiding this comment.
Should the holder address be transformed to lowercase, as done in line 102?
| ) | ||
|
|
||
| # Grant PAUSE_ROLE on WithdrawalQueue for the new GateSeal | ||
| validate_grant_role_event(events[18], PAUSE_ROLE, NEW_GATE_SEAL, contracts.agent) |
There was a problem hiding this comment.
Actually, validate_grant_role_event() doesn't check which address emitted the event
| ), | ||
| # Change GateSeal on WithdrawalQueue and ValidatorsExitBusOracle | ||
| ( | ||
| "19. Grant PAUSE_ROLE on WithdrawalQueue 0xc7cc160b58F8Bb0baC94b80847E2CF2800565C50 to the new GateSeal 0xAE6eCd77DCC656c5533c4209454Fd56fB46e1778", |
There was a problem hiding this comment.
Descriptions in items 19–22 contain instead of regular spaces. Is this intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.