Use brownie's Contract API to decode EVM script calls #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current EVM script decoder is based on the AVotesParser library. However, this library has a bug that, under certain conditions (e.g., when a call is made on proxy contracts), can result in unparsed calls in the output (see screenshot below):
Since AVotesParser is scheduled for deprecation in the near future, fixing the issue directly in the library is suboptimal.
This PR addresses the problem by eliminating the use of
AVotesParser.decode_function_call()and replacing it with a new local method,decode_encoded_call(). This method relies entirely on Brownie’s Contract API, which can natively resolve ABIs and source code from Etherscan, as well as decode call data.Note: The new implementation requires the
ETHERSCAN_TOKENenvironment variable to be set in order to run the scripts.Below is a screenshot showing the output of the updated script using the new method.: