Merge pull request #442 from lidofinance/feature/ui-918-update-typing…

…s-to-accept-react-nodes Feature/UI 918 update typings to accept react nodes
lidofinance · Aug 4, 2023 · da10b80 · da10b80
2 parents 851c59e + b3ceedb
commit da10b80
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/checkbox/Checkbox.tsx b/packages/checkbox/Checkbox.tsx
@@ -2,6 +2,7 @@ import {
   ComponentPropsWithoutRef,
   ForwardedRef,
   forwardRef,
+  ReactNode,
   RefObject,
 } from 'react'
 import { Text } from '../text'
@@ -12,7 +13,7 @@ import { Check } from '../icons'
 export type CheckboxProps = ComponentPropsWithoutRef<'input'> & {
   wrapperRef?: RefObject<HTMLLabelElement>
   children?: never
-  label?: string
+  label?: ReactNode
 }
 
 export const Checkbox = forwardRef(

diff --git a/packages/select/Option.tsx b/packages/select/Option.tsx
@@ -1,12 +1,18 @@
-import { ForwardedRef, MouseEvent, forwardRef, useCallback } from 'react'
+import {
+  ForwardedRef,
+  MouseEvent,
+  forwardRef,
+  useCallback,
+  ReactNode,
+} from 'react'
 import { PopupMenuItem, PopupMenuItemProps } from '../popup-menu'
 
 export type OptionValue = string | number
 export type OptionHandleChange = (value: OptionValue) => void
 
 export type OptionProps = Omit<PopupMenuItemProps, 'value' | 'children'> & {
   value: OptionValue
-  children: string
+  children: ReactNode
   onChange?: OptionHandleChange
 }