Simplified vite config #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jabher
approved these changes
Jul 12, 2023
Jabher
reviewed
Jul 13, 2023
vite.config.js
Outdated
| (id.startsWith('@') && | ||
| excluded.includes(id.split('/').slice(0, 2).join('/'))) | ||
| // direct node_modules import | ||
| id.includes('node_modules') || |
There was a problem hiding this comment.
Suggested change
| id.includes('node_modules') || | |
| id.includes('/node_modules/') || |
Jabher
reviewed
Jul 13, 2023
vite.config.js
Outdated
| // relative import is ok | ||
| id.startsWith('.') || | ||
| // absolute import is ok | ||
| id.startsWith('/') |
There was a problem hiding this comment.
absolute import is something that should never happen, actually
There was a problem hiding this comment.
(but maybe paths are transformed to absolute, I don't remember)
There was a problem hiding this comment.
Some ids are actually absolute paths for some reason, here is data sample
styled-components
./PopoverRoot
styled-components
../button
./PaginationItemStyles
./types
./PopoverRoot
../button
/Users/kozlovzxc/Projects/ui/packages/pagination/PaginationItemStyles.tsx
/Users/kozlovzxc/Projects/ui/packages/pagination/types.ts
/Users/kozlovzxc/Projects/ui/packages/popover/PopoverRoot.tsx
/Users/kozlovzxc/Projects/ui/packages/button/index.ts
Jabher
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like with
preserveModules: trueresolution works a bit differently, so it's not needed to write complexexternalfunction.Demo