Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to css modules addressbadge & identicon #401

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

hexnickk4997
Copy link
Contributor

@hexnickk4997 hexnickk4997 commented Jul 19, 2023

Description

Review & merge only after #400

Fixes UI-848

  • Moved AdderessBadge & Identicon
  • Updated tsconfig since we can't use baseUrl for the same reason as we can't use custom imports, it won't work in transpiled version (tsc doesn't fix import paths).

Demo

image image image

@hexnickk4997 hexnickk4997 requested review from a team as code owners July 19, 2023 13:20
Comment on lines +15 to +16
> = (props) => {
const { loading, ...rest } = props
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> = (props) => {
const { loading, ...rest } = props
> = ({ loading, ...rest }) => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one contains changes from the previous PR

@hexnickk4997 hexnickk4997 merged commit afedd4f into v4 Jul 19, 2023
@hexnickk4997 hexnickk4997 deleted the feature/ui-833-migrate-addressbadge branch July 19, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants