Updated theme to work via css variables #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinamaulitova
approved these changes
Aug 2, 2023
Jabher
reviewed
Aug 2, 2023
Comment on lines
+189
to
+190
| --lido-rgb-errorHover: 212, 76, 77; | ||
| --lido-color-errorContrast: #fff; |
There was a problem hiding this comment.
-rgb- is used in some of widgets for re-using color but making it transparent. please, preserve it in new version
Jabher
reviewed
Aug 2, 2023
| }> = ({ jsStyleScript = true, cssFont = false }) => ( | ||
| <> | ||
| {jsStyleScript ? <ScriptThemeValue /> : null} | ||
| {cssFont ? <Fonts /> : null} |
There was a problem hiding this comment.
Jabher
reviewed
Aug 2, 2023
| @@ -0,0 +1,44 @@ | |||
| const getDefinedVariables = async () => { | |||
| const content = await fs.readFile('./packages/theme/theme.css', 'utf-8') | |||
There was a problem hiding this comment.
leave annotation in theme.css that it is used here and should not be moved or renamed
There was a problem hiding this comment.
also, please add comment for this file - what is it doing?
Jabher
reviewed
Aug 2, 2023
| process.exit(1) | ||
| } | ||
|
|
||
| void main() |
There was a problem hiding this comment.
top-level await should be already supported, no need to wrap
Jabher
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also fixes UI-920
ContentTheme&ThemeTogglercomponents inside theme folder since they are directly related to theme functionalityThemeProvider, which accepts any theme anymoreDemo
Content Theme
Theme Providers
Theme Toggler
Cookie is also supported
Manually changed to light
System theme also supported