Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new configuration for the new UI kit #484

Merged
merged 13 commits into from
Dec 23, 2024
Merged

Create a new configuration for the new UI kit #484

merged 13 commits into from
Dec 23, 2024

Conversation

molok0aleks99
Copy link
Contributor

No description provided.

@molok0aleks99 molok0aleks99 requested review from a team as code owners November 20, 2024 07:38
@molok0aleks99 molok0aleks99 force-pushed the feature/we-1714-create-a-new-configuration-for-the-new-ui-kit branch from 0eaa9c1 to 593781c Compare November 26, 2024 07:59
@molok0aleks99 molok0aleks99 changed the title [Don't merge] Feature/we 1714 create a new configuration for the new UI kit Create a new configuration for the new UI kit Nov 26, 2024
tyhonchik
tyhonchik reviewed Nov 26, 2024
View reviewed changes
Copy link

@tyhonchik tyhonchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR. It's clear that a lot of effort was put into it.

I've left a few minor comments and suggestions that might be worth considering.

DiRaiks
DiRaiks approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@DiRaiks DiRaiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I only reviewed setting up the repository and publishing package configurations

tyhonchik
tyhonchik approved these changes Dec 19, 2024
View reviewed changes
Copy link

@tyhonchik tyhonchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of work, thank you

@molok0aleks99 molok0aleks99 merged commit 2f88460 into lido-ui-v4-canary Dec 23, 2024
9 checks passed
@molok0aleks99 molok0aleks99 deleted the feature/we-1714-create-a-new-configuration-for-the-new-ui-kit branch December 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiRaiks DiRaiks DiRaiks approved these changes

@tyhonchik tyhonchik tyhonchik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@molok0aleks99 @DiRaiks @tyhonchik