-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use proper form of specs2 dependency #1812
Conversation
Seems like this guy is missing the dependency for the extra matchers that can do XML and such. If you don't have a chance to look at it I'll see if I can get it over the coming days as I wrestled with this on for lift-formality recently. |
|
required for compatibility with Scala 2.12 community build. and it's the recommended thing anyway
I added myself to As for adding the dependencies needed to make the But then I started to have to make decisions about how best to fit the additional JARs into the existing structure of the build, and I don't really understand how you're using I have now checked the "Allow edits from maintainers" checkbox. |
Sweet, I'll try and have a look over the next couple of days if no one beats me to it. Thanks! |
3.7 splits out specs2 into several sub-packages, and we need 3 of them for most specs and 2 for webkit's test helpers.
Ookay, I think this guy should be good to go. Let's see what travis says 💥 |
Travis says yes, I'm going to go ahead and merge since this isn't a functional change. |
@SethTisue hope this helps, sorry for the delay! |
thanks Antonio! this allowed scala/community-build#394 |
🎉 Awesome :) |
required for compatibility with Scala 2.12 community build.
and it's the recommended thing anyway