#495 Add Support For Set Types In Config Beans #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks generally good. Something isn't passing CI, needs investigation. |
karthicks
force-pushed
the
issue-495
branch
from
5ffa959 to
002de45
Compare
|
@havocp , resolved the build issue, sorry about that. Please take another look when you get a chance, thanks! |
havocp
approved these changes
Sep 16, 2017
|
Thanks! |
|
cool idea, thanks :) |
aalleexxeeii
pushed a commit
to aalleexxeeii/typesafe-config
that referenced
this pull request
Jun 6, 2018
lightbend#495 Add Support For Set Types In Config Beans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following issue: #495