Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish with namespaced JDK9 module name #547

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Publish with namespaced JDK9 module name #547

merged 1 commit into from
Feb 21, 2018

Conversation

jroper
Copy link
Member

@jroper jroper commented Feb 21, 2018

Fixes #546.

Adds Automatic-Module-Name: typesafe.config, rather than defaulting to the very generic module name of config that the JVM selects.

This PR depends on sbt-osgi 0.9.3 being published for sbt 0.13 (it's been published for sbt 1.0 but not 0.13) to get sbt/sbt-osgi#48.

@jroper
Publish with namespaced JDK9 module name
dcd1435 
Fixes lightbend#546.

Adds Automatic-Module-Name: typesafe.config, rather than defaulting to
the very generic module name of config that the JVM selects.
@havocp
Copy link
Collaborator

havocp commented Feb 21, 2018

Might be better if someone who knows more about the JDK9 module stuff looks at this, rather than me, since if this were wrong I couldn't tell you :-) but fine with me to merge once CI passes (which seems to be a matter of the sbt-osgi update you mentioned).

@ktoso ktoso mentioned this pull request Feb 21, 2018
Closed
ktoso
ktoso approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Released sbt osgi sbt/sbt-osgi#51

@ktoso
Copy link
Contributor

ktoso commented Feb 21, 2018

The module name is ok. I guess one could debate about lightbend.config, but let's not since the package is still typesafe and it'd be confusing.

LGTM

@jroper
Copy link
Member Author

jroper commented Feb 21, 2018

Making it lightbend.config now will mean if/when we change the package name to com.lightbend.config, that typesafe config and lightbend config won't be able to exist on the module path at the same time, as their module names will conflict - that is to say, it will force a lockstep upgrade of the typesafe config to lightbend config of the whole ecosystem.

@ktoso
Copy link
Contributor

ktoso commented Feb 21, 2018

That's what I said... don't discuss and it's good as is.

@ktoso ktoso merged commit 76ff0bd into lightbend:master Feb 21, 2018
@ktoso
Copy link
Contributor

ktoso commented Feb 21, 2018

Anyone minds if we release a new version with this? I could cut it.

Anything else we'd want to include before such release? @2m @havocp

@ktoso ktoso modified the milestone: 1.3.3 Feb 21, 2018
@havocp
Copy link
Collaborator

havocp commented Feb 21, 2018

#538 and #534 maybe. No objections to releasing.

@2m
Copy link
Contributor

2m commented Feb 21, 2018

No objections here as well.

aalleexxeeii pushed a commit to aalleexxeeii/typesafe-config that referenced this pull request Jun 6, 2018
@jroper @ktoso
Publish with namespaced JDK9 module name (lightbend#547)
d284ee5 
Fixes lightbend#546.

Adds Automatic-Module-Name: typesafe.config, rather than defaulting to
the very generic module name of config that the JVM selects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jroper @havocp @ktoso @2m