RFC: Sample architecture & code skeleton #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues: * Explicitly specify radix for header bits field parsing and * Handle confirmations being negative (ie reorg'ed out)
This is a meaningful rewrite of the previous sample rust-lightning based node. Mainly, it switches the code architecture to a new threading model, where each major LN components gets its own and communicate with others through dedidcated channels. It also splits the command line in its own binary, move logging in its own file, and vets the whole with a configuration file. Documentation is work in progress and aims to expose Rust-Lightning architecture usage. This is still experimental software and shouldn't be used beyond a local regtest. You still have wide holes which would provoke certain loss of funds.
jkczyz
added a commit
to jkczyz/ldk-sample
that referenced
this pull request
Feb 22, 2021
|
Feel free to take jkczyz@f7119d5, which builds on the current rust-lightning plus lightningdevkit/rust-lightning#791. |
|
Closing for now, going to look on the new version soon. |
orbitalturtle
added a commit
to orbitalturtle/ldk-sample
that referenced
this pull request
Jan 17, 2024
Make configuration and start function public so they can be imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1 after solving git history divergences conflicts.
Please note the new
ARCH.mddetailing sample initialization.