Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routing::gossip::tests::test_channel_timeouts is flaky #1914

Closed
TheBlueMatt opened this issue Dec 12, 2022 · 1 comment · Fixed by #1953
Closed

routing::gossip::tests::test_channel_timeouts is flaky #1914

TheBlueMatt opened this issue Dec 12, 2022 · 1 comment · Fixed by #1953
Milestone
0.0.114

Comments

@TheBlueMatt
Copy link
Collaborator

On Windows CI (ie a really slow machine), we get


failures:

---- routing::gossip::tests::test_channel_timeouts stdout ----
thread 'routing::gossip::tests::test_channel_timeouts' panicked at 'assertion failed: network_graph.removed_channels.lock().unwrap().is_empty()', lightning\src\routing\gossip.rs:2550:13


failures:
    routing::gossip::tests::test_channel_timeouts

test result: FAILED. 582 passed; 1 failed; 2 ignored; 0 measured; 0 filtered out; finished in 32.11s
@TheBlueMatt TheBlueMatt added this to the 0.0.114 milestone Dec 12, 2022
@TheBlueMatt TheBlueMatt mentioned this issue Dec 12, 2022
Merged
@valentinewallace
Copy link
Contributor

Also running into this on #1812, but in benchmark: https://github.com/lightningdevkit/rust-lightning/actions/runs/3732711432/jobs/6332523097

arik-so added a commit to arik-so/rust-lightning that referenced this issue Jan 14, 2023
@arik-so
Debug lightningdevkit#1914.
603922c
arik-so added a commit to arik-so/rust-lightning that referenced this issue Jan 14, 2023
@arik-so
Add error messages to stale gossip cleanup assertions.
e9d4ae1 
Should help debug lightningdevkit#1914.
arik-so added a commit to arik-so/rust-lightning that referenced this issue Jan 14, 2023
@arik-so
Allow manually passing a timestamp to channel_failed. Fixes lightni…
16deda0 
…ngdevkit#1914.
@arik-so arik-so mentioned this issue Jan 14, 2023
Merged
vss96 pushed a commit to vss96/rust-lightning that referenced this issue Mar 6, 2023
@arik-so
Add error messages to stale gossip cleanup assertions.
95d95a3 
Should help debug lightningdevkit#1914.
vss96 pushed a commit to vss96/rust-lightning that referenced this issue Mar 6, 2023
@arik-so
Allow manually passing a timestamp to channel_failed. Fixes lightni…
9d50b57 
…ngdevkit#1914.
optout21 pushed a commit to optout21/rust-lightning that referenced this issue Jul 24, 2023
@arik-so @optout21
Add error messages to stale gossip cleanup assertions.
03931ff 
Should help debug lightningdevkit#1914.
optout21 pushed a commit to optout21/rust-lightning that referenced this issue Jul 24, 2023
@arik-so @optout21
Allow manually passing a timestamp to channel_failed. Fixes lightni…
f3b1517 
…ngdevkit#1914.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.114
Development

Successfully merging a pull request may close this issue.

Fix stale gossip retention Heisenbug when channel updates are slow. arik-so/rust-lightning
2 participants
@TheBlueMatt @valentinewallace