Standardize trait derives in network message and graph objects #803
Conversation
|
ACK a05b51a. It may also be worth adding |
TheBlueMatt
force-pushed
the
2021-02-derives
branch
2 times, most recently
from
d1627c3 to
1171a0b
Compare
Codecov Report
@@ Coverage Diff @@
## main #803 +/- ##
==========================================
+ Coverage 90.80% 90.84% +0.04%
==========================================
Files 45 45
Lines 24547 24547
==========================================
+ Hits 22289 22300 +11
+ Misses 2258 2247 -11
Continue to review full report at Codecov.
|
In general, trivial structs that have no inner logic can/should all derive, at least, `Clone, Debug, PartialEq`.
In general, trivial structs that have no inner logic can/should all derive, at least, `Clone, Debug, PartialEq`.
TheBlueMatt
force-pushed
the
2021-02-derives
branch
from
1171a0b to
c229735
Compare
|
Rebased and updated the auto-generated bindings with new clones. |
| #[cfg(not(feature = "fuzztarget"))] | ||
| pub(crate) features: InitFeatures, | ||
| #[cfg(feature = "fuzztarget")] | ||
| /// The relevant features which the sender supports | ||
| pub features: InitFeatures, |
There was a problem hiding this comment.
I take it this was necessary for the bindings?
There was a problem hiding this comment.
I'm honestly not sure why it was here, I think it's just left over from when we had all the message guts hidden instead of exposed. Features is a well-exposed type now, though.
In general, trivial structs that have no inner logic can/should
all derive, at least,
Clone, Debug, PartialEq.