Add support for sqlite/postgres database backends #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
positiveblue
force-pushed
the
sql
branch
3 times, most recently
from
735c78d to
82ca797
Compare
|
@guggero: review reminder |
Roasbeef
requested changes
Jun 7, 2023
guggero
reviewed
Jun 12, 2023
Roasbeef
requested changes
Jun 14, 2023
There was a problem hiding this comment.
Look preeetty good, ran things locally and found an issue with the sqlite file config if one isn't explicitly specified. I think we want to allow people to just say db_backend: sqlite and not have to explicitly set where the file should go (actually use the default).
positiveblue
force-pushed
the
sql
branch
2 times, most recently
from
6192579 to
4f26827
Compare
guggero
approved these changes
Jun 14, 2023
|
Needs a rebase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sqlite/postgres support for aperture.
Currently the server uses a couple of interfaces
SecretStoreandOnionStorethat are implemented in this PR. To keep consistency with other code bases aperture uses the same toolssqlc/goang-migrateand the same interfaces than Taproot AssetsFixes #95