Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool+order: display fee estimates in the order form #243

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

jamaljsr
Copy link
Member

Based on #242

This PR makes use of the new QuoteOrder RPC in Pool to display fee estimates in the order form. The values automatically update then the user modifies the order form fields. The new fee rows also have tooltips to provide more helpful information.

image

@jamaljsr jamaljsr requested a review from guggero June 30, 2021 05:56
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM 💯

Just one small UX improvement idea that is totally non-blocking.

}

/** quote order at most once every 2 seconds when using this func */
quoteOrderThrottled = debounce(this.quoteOrder, 2000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tripped me up a bit. I changed some values and expected the quote to be updated. Was almost ready to enter yet another number when I noticed the number finally updated. Maybe I'm just too impatient.

If it's easy to implement (probably not worth doing if it requires a lot of effort), we could invalidate the quote fields (for example by showing a loading animation) until the next debounce run comes along. That way the user knows something's going to happen soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good point. I like the idea of displaying a loader. I can do that quickly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the loaders and decreased the debounce to 1 second. Thanks for the suggestion

@jamaljsr jamaljsr merged commit 2b1b039 into master Jun 30, 2021
@jamaljsr jamaljsr deleted the quote-order branch June 30, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants