Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Match and pass /litrpc.* locations in nginx #306

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

dongcarl
Copy link

@dongcarl dongcarl commented Jan 5, 2022

Also escape the "." for more precise regex matching

Not matching /litrpc.* locations results in lost grpc calls, which looks like this to the user:
image

Also escape the "." for more precise regex matching
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and simplification! LGTM 🎉

@guggero guggero requested a review from jamaljsr January 5, 2022 08:21
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Roasbeef Roasbeef merged commit 394ff6c into lightninglabs:master Jan 5, 2022
dennisreimann added a commit to dennisreimann/btcpayserver-docker that referenced this pull request Feb 16, 2022
NicolasDorier pushed a commit to btcpayserver/btcpayserver-docker that referenced this pull request Feb 16, 2022
* Upgrade Lightning Terminal to v0.6.2-alpha

Closes btcpayserver/btcpayserver#3459

* Add LIT_PASSWD to .env

* Fix and simplify LiT nginx config

See lightninglabs/lightning-terminal#306.

Fixes #601

* Mount correct LiT data directory

Fixes #592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants