cmd/litcli: change default session expiry to 3 months #334
Conversation
The default expiry of one hour was way too short for anything practical and we increase it to 90 days which is almost three months. The user can still override this value manually by specifying the flag.
|
As mentioned offline, won't matter once the second handshake is introduced into LNC, but good to patch this up now so people don't need to regenerate pairing phrases if they don't immediately use one of them. |
|
Hmm, I think I missed or misunderstood that part. So the expiry was always thought of as "maximum time until first use/pairing" and not as "make sure a session cannot be used indefinitely by adding a maximum lifetime"? Or would we instead implement the maximum lifetime (once the second handshake is implemented) through a macaroon caveat? Or would a session be "valid until manually revoked"? |
Ah no it's me that's misunderstanding, you're correct in that after we introduce the second handshake, this all still applies. |
|
The only other change that'll come along with the second handshake is that we'd disallow using the pairing phrase again (naive impl would be just to delete/forget it on the server side). |
The default expiry of one hour was way too short for anything practical
and we increase it to 90 days which is almost three months.
The user can still override this value manually by specifying the flag.