Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui+sessions: improve when expiry label displays Never #382

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

jamaljsr
Copy link
Member

Based on #358

This PR fixes a minor UI issue where the Expiry label displays the far off date values instead of "Never. This occurs when the session was created by a user in a different time zone.

image

@jamaljsr jamaljsr requested a review from guggero June 24, 2022 18:30
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM 🎉

@guggero guggero merged commit 2d08433 into enable-second-handshake Jun 27, 2022
@guggero guggero deleted the fix-expiry-label branch June 27, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants