Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itest: export ServerHarness and HarnessNode #546

Merged

Conversation

ViktorTigerstrom
Copy link
Contributor

In this PR we export the itest structs ServerHarness and HarnessNode. This is useful to make it possible to use the structures independently in other test frameworks that need to run and interact with Lit instance(s), and reuse the structures from the lightning-terminal repo.

Let me know if there are other components of the itest framework that you think would be useful to export, and I'll update this PR with those as well :)!

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's wait until the dependent PR is ready to go before merging this in just so that we can make any last minute exports here if needed.

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependent PR looks good soooo......LGTM 🔥

@ellemouton ellemouton requested a review from bitromortac May 11, 2023 08:27
Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ellemouton ellemouton merged commit 9131690 into lightninglabs:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants