Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: install litcli with make go-install-cli #560

Conversation

ViktorTigerstrom
Copy link
Contributor

This PR adds installation of the litcli executable when running the make go-install-cli command. The command should install all cli executables.

Happy to address any feedback! :)

Makefile Outdated Show resolved Hide resolved
@ViktorTigerstrom ViktorTigerstrom force-pushed the 2023-05-make-add-litcli-install branch from dfd2899 to 9b584f1 Compare May 30, 2023 09:54
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 👌

@jamaljsr
Copy link
Member

Just needs a rebase to merge.

@ViktorTigerstrom ViktorTigerstrom force-pushed the 2023-05-make-add-litcli-install branch from 9b584f1 to ed0e713 Compare June 16, 2023 20:01
@ViktorTigerstrom
Copy link
Contributor Author

Rebased! No changes made.

@ellemouton ellemouton merged commit 190b50d into lightninglabs:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants