rules+session_rpc: use existing privacy mapper for obfuscating rules of linked sessions #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
usePrevPrivMapForLinkedRules
branch
from
7f5c99a to
9bd69b6
Compare
ViktorTigerstrom
approved these changes
Aug 31, 2023
bitromortac
approved these changes
Aug 31, 2023
ellemouton
force-pushed
the
usePrevPrivMapForLinkedRules
branch
2 times, most recently
from
44a2ab9 to
be65af1
Compare
bitromortac
reviewed
Aug 31, 2023
ellemouton
force-pushed
the
usePrevPrivMapForLinkedRules
branch
from
be65af1 to
9d1cf4e
Compare
There was a problem hiding this comment.
New fixes looks good 🚀 !
Leaving some suggestions for the PrivacyMapPairs.Add that's non-blocking, and one small issue that I think should be fixed.
Amazed at the speed you're implementing these fixes @ellemouton, it's incredibly impressive 😃!!
This commit adds a new FetchAllPairs to the PrivacyMapTx interface. This method returns a new PrivacyMapPairs struct which is an in-memory privacy map DB. The PrivacyMapPairs struct implements a new PrivacyMapReader interface which can be used to pass around read only access to the PrivacyMapPairs struct.
This commit expands the RealToPseudo methods to take in a privacy map db reader. This allows the methods to check if the privacy map db already contains an entry for a "real" string before generating a new one. For now, only an empty PrivacyMapReader is ever provided to the RealToPseudo call. This will be changed in the following commit.
In this commit, we keep track of all known privacy map pairs for a session along with any new pairs to be persisted.
ellemouton
force-pushed
the
usePrevPrivMapForLinkedRules
branch
from
9d1cf4e to
7bb4d3b
Compare
ViktorTigerstrom
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we ensure that if we are linking a session to a previous one, that we extract any existing real-to-pseudo pairs from the privacy map DB instead of generating new ones.