-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add keysend messenger to custom permissions #684
feat: add keysend messenger to custom permissions #684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK LGTM 🚀
Thanks for submitting the PR. I've tested this and confirmed it works as expected. The code looks great as well.
I'd just like to confirm with @levmi that the copy is ok before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, love to see it! Happy to get this in :)
Just one nit on copy, ideally, we could adjust to "User can send and receive payments plus sign messages". I'm okay with title remaining "Keysend Messenger".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to check this out - very cool - thanks for the PR @secondl1ght!
And ACK to @levmi's copy suggestion to keep the description consistent.
Woot! Thanks for the review guys - I adjusted the copy, I agree it reads better this way. One other thing I was thinking about is that instead of having the expected values for Happy to push one more commit to this PR to add typing to this variable if you guys think it is a good idea. |
Sounds good. Feel free to make that refactoring here in this PR. |
Ok cool, I just pushed a commit adding a type. Please let me know what you think! 🙌🏼 |
Awesome! Really love to see the external contribution here. If you ever want to add anything else to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the latest commits. Everything looks great!
Thanks for the refactoring as well. LGTM 🚀
Awesome thanks everyone! I will definitely continue to contribute to the LL repos when I have some time. 🙂 |
Added a new option to the Custom Permissions view when creating a new LNC session. It is called 'Keysend Messenger' which allows to send/receive payments, plus sign messages. This preset can be used in apps such as Cipherchat for example. Users will now also be able to add Sign Message to their Custom permissions as well.