-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StaticAddr: merge staging to master #853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
static-addr-staging
branch
3 times, most recently
from
November 19, 2024 12:29
5f09927
to
fa759a9
Compare
hieblmi
force-pushed
the
static-addr-staging
branch
from
November 21, 2024 15:09
fa759a9
to
6982adb
Compare
hieblmi
commented
Dec 2, 2024
hieblmi
force-pushed
the
static-addr-staging
branch
3 times, most recently
from
December 10, 2024 10:44
73c2f22
to
b1c19e8
Compare
hieblmi
force-pushed
the
static-addr-staging
branch
3 times, most recently
from
December 12, 2024 17:20
d326a3b
to
818562f
Compare
This commit adds support for the new notification of type NotificationTypeStaticLoopInSweepRequest. This notification is sent when a sweep request is received from the server.
This commit adds the listening for sweep requests from the server. On a sweep request the loopin manager will fetch the loop in from the db, do sanity and safety checks and then sign the psbt for the input and send it back to the server.
This commit updates the loop in FSM to handle the new server based
hieblmi
force-pushed
the
static-addr-staging
branch
from
December 12, 2024 17:31
818562f
to
9342b0f
Compare
hieblmi
force-pushed
the
static-addr-staging
branch
from
December 18, 2024 08:38
7a1cb63
to
acea303
Compare
sputn1ck
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Congrats on the release
bhandras
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the static address loop-in feature to the main repository branch.