Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custodian should emit an RPC notification status event when the recieve process completes sucessfully #650

Closed
ffranr opened this issue Nov 3, 2023 · 3 comments · Fixed by #659
Assignees
Labels
enhancement New feature or request sending
Milestone

Comments

@ffranr
Copy link
Contributor

ffranr commented Nov 3, 2023

The custodian handles receiving assets. It should emit an RPC notification status event over the subscribers channel which is initialised via the RPC endpoint SubscribeReceiveAssetEventNtfns. This feature was requested by a user on slack here.

Currently, the custodian does emit events emanating from the proof courier. This is an example of an event notification sent to subscribers:

subscriberEvent(waitEvent)

The new event should implement the fn.Event interface. It should contain (as fields) the corresponding address by which the asset was sent.

The new event should be emitted at this point:

@dstadulis
Copy link
Collaborator

Would like to consider what other event notifications could be added that may be helpful applications to use

@ffranr
Copy link
Contributor Author

ffranr commented Nov 13, 2023

Would like to consider what other event notifications could be added that may be helpful applications to use

@dstadulis A user on Slack requested an event notification which would be published once a sufficient number of confirmation block had been mined. (Confirming an asset transfer.)

@dstadulis
Copy link
Collaborator

How about just subscribe to confirmation count or reporting when the tap client meets it's "confirmed" threshold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sending
Projects
Status: ✅ Done
3 participants