Custodian emits a new asset-receive-complete event to notification subscribers #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
force-pushed
the
add-recv-complete-event
branch
from
03995f8 to
fde04c9
Compare
dstadulis
changed the title
ffranr
force-pushed
the
add-recv-complete-event
branch
from
fde04c9 to
0674091
Compare
ffranr
force-pushed
the
add-recv-complete-event
branch
2 times, most recently
from
f45f63d to
a36addd
Compare
GeorgeTsagk
approved these changes
Nov 14, 2023
ffranr
force-pushed
the
add-recv-complete-event
branch
from
a36addd to
0fd34a9
Compare
ffranr
force-pushed
the
add-recv-complete-event
branch
2 times, most recently
from
3b75336 to
5437bc5
Compare
jharveyb
approved these changes
Nov 27, 2023
AssetReceiveCompleteEvent is a new event added in this commit. It is published by the custodian to status event subscribers once the asset receive process is complete.
We were previously setting up an asynchronous routine and the immediately blocking until the routine had finished. This commit simplifies the code by removing that unnecessary asynchronous setup.
This commit adds an assertion function which blocks until the receiver tapd node publishes an asset receive complete event.
ffranr
force-pushed
the
add-recv-complete-event
branch
from
5437bc5 to
6cacee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #650