Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Typo in batch state: BATCH_STATE_PEDNING should be BATCH_STATE_PENDING #690

Closed
alex-georgiou opened this issue Nov 21, 2023 · 1 comment · Fixed by #692
Closed
Assignees
Labels
bug Something isn't working needs triage

Comments

@alex-georgiou
Copy link

alex-georgiou commented Nov 21, 2023

Background

Not really a bug, more of a typo. But it can create confusion.

BATCH_STATE_PEDNING should be BATCH_STATE_PENDING.

I found this typo in at least three places in the code.

Since the software is still alpha, perhaps you could fix this without worrying about compatibility issues with other software.

Your environment

tapcli version 0.3.0-alpha commit=v0.3.0
tapd version 0.3.0-alpha commit=v0.3.0
@alex-georgiou alex-georgiou added bug Something isn't working needs triage labels Nov 21, 2023
@GeorgeTsagk
Copy link
Member

Hey @alex-georgiou

Yes this typo was probably originally made in mint.proto and after compiling the rpc bindings it propagated into the code :)

Thanks for flagging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants