Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc+rpcserver: fix batch state typo #692

Merged
merged 1 commit into from
Nov 27, 2023
Merged

rpc+rpcserver: fix batch state typo #692

merged 1 commit into from
Nov 27, 2023

Conversation

GeorgeTsagk
Copy link
Member

Closes #690

@GeorgeTsagk GeorgeTsagk self-assigned this Nov 21, 2023
@jharveyb jharveyb self-requested a review November 22, 2023 15:59
jharveyb
jharveyb approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, those are the only uses I see and we don't directly compare to this state in the itests AFAICT.

@GeorgeTsagk GeorgeTsagk requested a review from ffranr November 23, 2023 15:39
ffranr
ffranr approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GeorgeTsagk GeorgeTsagk added this pull request to the merge queue Nov 27, 2023
Merged via the queue into lightninglabs:main with commit 0970d94 Nov 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharveyb jharveyb jharveyb approved these changes

@ffranr ffranr ffranr approved these changes

Assignees

@GeorgeTsagk GeorgeTsagk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Typo in batch state: BATCH_STATE_PEDNING should be BATCH_STATE_PENDING
3 participants
@GeorgeTsagk @ffranr @jharveyb