Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #1269

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Improve logging #1269

merged 6 commits into from
Jan 7, 2025

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Jan 2, 2025

Refine selected log messages to enhance clarity and reduce clutter in log files.

Also add log messages for price oracle query.

ffranr added 3 commits January 2, 2025 13:55
Change the log level from debug to trace for unhandled channel update
messages. This reduces noise in the debug logs while still allowing
visibility when needed.
Improve logging for HandleTraffic method to include fundingBlob in
hexadecimal format
Updated the syncServerState method to log the server address in string
format. This change simplifies log entries, improving clarity and
reducing clutter in log files.
@ffranr ffranr added the logging label Jan 2, 2025
@ffranr ffranr requested review from gijswijs and GeorgeTsagk January 2, 2025 14:10
@ffranr ffranr self-assigned this Jan 2, 2025
Corrected the log message to use "bid" instead of "ask" as the original
term was incorrect.
@coveralls
Copy link

coveralls commented Jan 2, 2025

Pull Request Test Coverage Report for Build 12631612950

Details

  • 0 of 21 (0.0%) changed or added relevant lines in 5 files are covered.
  • 26 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.03%) to 40.94%

Changes Missing Coverage Covered Lines Changed/Added Lines %
universe/auto_syncer.go 0 1 0.0%
server.go 0 2 0.0%
tapchannel/aux_funding_controller.go 0 2 0.0%
fn/option.go 0 5 0.0%
rfq/negotiator.go 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
tapchannel/aux_leaf_signer.go 2 43.08%
universe/interface.go 5 50.65%
asset/asset.go 5 80.75%
tapchannel/aux_invoice_manager.go 6 83.25%
asset/mock.go 6 92.24%
Totals Coverage Status
Change from base Build 12417405641: -0.03%
Covered Lines: 26402
Relevant Lines: 64490

💛 - Coveralls

fn/option.go Show resolved Hide resolved
rfq/negotiator.go Show resolved Hide resolved
ffranr added 2 commits January 6, 2025 11:22
Introduce the `String` method for `Option` to improve logging
capabilities.
Log a message when querying the price oracle service via the
`QueryAskPrice` endpoint to improve traceability and debugging.
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🔥

@ffranr ffranr added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 8719b40 Jan 7, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants