-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging #1269
Merged
Merged
Improve logging #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the log level from debug to trace for unhandled channel update messages. This reduces noise in the debug logs while still allowing visibility when needed.
Improve logging for HandleTraffic method to include fundingBlob in hexadecimal format
Updated the syncServerState method to log the server address in string format. This change simplifies log entries, improving clarity and reducing clutter in log files.
Corrected the log message to use "bid" instead of "ask" as the original term was incorrect.
Pull Request Test Coverage Report for Build 12631612950Details
💛 - Coveralls |
bhandras
approved these changes
Jan 2, 2025
Introduce the `String` method for `Option` to improve logging capabilities.
Log a message when querying the price oracle service via the `QueryAskPrice` endpoint to improve traceability and debugging.
ffranr
force-pushed
the
improve-logging
branch
from
January 6, 2025 11:23
60d3ebe
to
ee22f42
Compare
GeorgeTsagk
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine selected log messages to enhance clarity and reduce clutter in log files.
Also add log messages for price oracle query.